[
https://issues.apache.org/jira/browse/HBASE-5746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619970#comment-13619970
]
Ted Yu commented on HBASE-5746:
-------------------------------
Patch looks good to me.
{code}
+ * sets the dummy header bytes
*/
- public int getHeaderSize();
+ public void setDummyHeader(byte[] headerBytes);
{code}
Can you add @param for headerBytes ?
{code}
+ * Return the appropriate DUMMY_HEADER for the minor version
+ */
+ public byte[] getDummyHeaderForVersion() {
...
+ * Return the appropriate DUMMY_HEADER for the minor version
+ */
+ static private byte[] getDummyHeaderForVersion(int minorVersion) {
{code}
Please use @return in javadoc.
> HFileDataBlockEncoderImpl uses wrong header size when reading HFiles with no
> checksums (0.96)
> ---------------------------------------------------------------------------------------------
>
> Key: HBASE-5746
> URL: https://issues.apache.org/jira/browse/HBASE-5746
> Project: HBase
> Issue Type: Sub-task
> Components: io, regionserver
> Reporter: Lars Hofhansl
> Assignee: Sergey Shelukhin
> Priority: Critical
> Fix For: 0.95.0
>
> Attachments: 5720-trunk-v2.txt, HBASE-5746-v0.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
