[ 
https://issues.apache.org/jira/browse/HBASE-8158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619993#comment-13619993
 ] 

Andrew Purtell commented on HBASE-8158:
---------------------------------------

The trunk/0.95 patch is not factored for hadoop-compat and this seems like the 
sort of compatibility issue that was designed for. For 0.94 reflection makes 
sense. For 0.95+, the same code in hadoop-compat-1 makes sense, for 
hadoop-compat-2 we can assume JarFinder is there since Hadoop 2 code is >= 
0.23. 

I would commit this to 0.94 (ping [~lhofhansl]) and maybe take it on the chin 
if there's test issues :-) because the patch looks good, the work on this issue 
looks good, and there has been good review. However I would like to hold off 
until a change goes in through trunk first. Please let me know your thoughts on 
the above comment.
                
> Backport HBASE-8140 "TableMapReduceUtils#addDependencyJar fails when nested 
> inside another MR job"
> --------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-8158
>                 URL: https://issues.apache.org/jira/browse/HBASE-8158
>             Project: HBase
>          Issue Type: Bug
>          Components: mapreduce
>    Affects Versions: 0.94.7
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>         Attachments: 8158-port-jarfinder-0.94.patch, 
> 8158-port-jarfinder-0.94.patch, 8158-port-jarfinder-0.94.patch, 
> 8158-port-jarfinder-0.94.patch, 8158-port-jarfinder-0.94.patch, 
> 8158-trunk-parity.patch
>
>
> Assess the stability of the JarFinder util class from Hadoop-2, as a 
> candidate for backporting to 0.94.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to