[
https://issues.apache.org/jira/browse/HBASE-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621340#comment-13621340
]
Sergey Shelukhin commented on HBASE-8248:
-----------------------------------------
This is curious. And this line also causes the failure, but in a very strange
manner.
What happens here is this. We call unassign and pass sn which is server name
taken from the node, which is in CLOSING state in this case, as region move
destination.
Clearly this is bogus, because server name in the node is closing the region.
So I think the change is correct.
The tests fail because they set up a mockito mock that expects null for
sendRegionClose (called from unassign); so, previously this mock was never
invoked. Now it is invoked and breaks the test. Which makes me wonder about
these tests.
I am attaching the patch where mocks are removed. Alternatively I can keep
passing sn to unassign here (RS will ignore it anyway with this patch if it
happens to be RS itself indeed), add a comment, and file separate JIRA for
tests that are suspect.
> HConnectionManager moved region tracking can cause the region server to
> redirect to itself; load balancer uses incorrect servername compare
> -------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-8248
> URL: https://issues.apache.org/jira/browse/HBASE-8248
> Project: HBase
> Issue Type: Bug
> Components: Client
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Fix For: 0.95.0
>
> Attachments: HBASE-8248-v0.patch
>
>
> hbase-hbase-regionserver-ip-10-152-131-248.log:2013-04-02 16:48:24,499 INFO
> org.apache.hadoop.hbase.regionserver.HRegionServer: Adding moved region
> record: c52aa9838fe14b28b34f1e4e5fa14be9 to
> ip-10-152-131-248.ec2.internal,60020,1364935613234:60020 as of 51312
> The consequences are obvious...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
