[
https://issues.apache.org/jira/browse/HBASE-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621424#comment-13621424
]
Ted Yu edited comment on HBASE-8259 at 4/3/13 10:31 PM:
--------------------------------------------------------
Nice catch.
{code}
+ // and not the value specified in the enum definition. so we can't add
stuff in the middle.
+ C_M_SNAPSHOT_TABLE (48), // Client asking Master to snapshot an
offline table
+ C_M_RESTORE_SNAPSHOT (49); // Client asking Master to snapshot an
offline table
{code}
Should the numeric values for the above two enum's be increased after the
movement ?
I understand the numeric values (48, 49 currently) are not used. The question
is just for readability.
was (Author: [email protected]):
Nice catch.
{code}
+ // and not the value specified in the enum definition. so we can't add
stuff in the middle.
+ C_M_SNAPSHOT_TABLE (48), // Client asking Master to snapshot an
offline table
+ C_M_RESTORE_SNAPSHOT (49); // Client asking Master to snapshot an
offline table
{code}
Should the numeric value for the above two enum's be increased after the
movement ?
> Snapshot backport in 0.94.6 breaks rolling restarts
> ---------------------------------------------------
>
> Key: HBASE-8259
> URL: https://issues.apache.org/jira/browse/HBASE-8259
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.6
> Reporter: Jean-Daniel Cryans
> Assignee: Matteo Bertozzi
> Priority: Blocker
> Fix For: 0.94.7
>
> Attachments: HBASE-8259-v0.patch
>
>
> [~aleksshulman] found with his nifty QA tools that 0.94.6 has an incompatible
> change due to HBASE-7360 (Snapshot 0.94 Backport) that breaks rolling
> restarts.
> RegionTransitionData.write() uses eventType.ordinal() that is the index in
> the enum and not the value specified in the enum definition. It means we
> can't add new states in the middle of the list. This can be fixed by moving
> C_M_SNAPSHOT_TABLE and C_M_RESTORE_SNAPSHOT at the end of the list. Trunk
> does the right thing already.
> Right now, RIT znodes created with 0.94.6 (or top of the branch) will use the
> wrong value for the event type. You will see things like:
> {noformat}
> 2013-04-03 14:57:25,197 DEBUG org.apache.hadoop.hbase.zookeeper.ZKAssign:
> regionserver:60020-0x13dd1e10dbd0004 Attempting to transition node
> 70236052/-ROOT- from M_ZK_REGION_OFFLINE to RS_ZK_REGION_OPENING
> 2013-04-03 14:57:25,201 WARN org.apache.hadoop.hbase.zookeeper.ZKAssign:
> regionserver:60020-0x13dd1e10dbd0004 Attempt to transition the unassigned
> node for 70236052 from M_ZK_REGION_OFFLINE to RS_ZK_REGION_OPENING failed,
> the node existed but was in the state M_SERVER_SHUTDOWN set by the server
> 192.168.1.112,60020,1365026237977
> 2013-04-03 14:57:25,201 WARN
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler: Failed
> transition from OFFLINE to OPENING for region=70236052
> 2013-04-03 14:57:25,201 WARN
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler: Region was
> hijacked? It no longer exists, encodedName=70236052
> {noformat}
> We should roll a 0.94.6.1 or 0.94.7 as soon this is fixed IMO.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
