[
https://issues.apache.org/jira/browse/HBASE-7750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625217#comment-13625217
]
Hadoop QA commented on HBASE-7750:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12577490/HBASE-7750-trunk.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces lines longer than
100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/5178//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5178//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5178//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5178//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5178//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5178//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5178//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5178//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5178//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/5178//console
This message is automatically generated.
> We should throw IOE when calling HRegionServer#replicateLogEntries if
> ReplicationSink is null
> ---------------------------------------------------------------------------------------------
>
> Key: HBASE-7750
> URL: https://issues.apache.org/jira/browse/HBASE-7750
> Project: HBase
> Issue Type: Bug
> Components: Replication
> Affects Versions: 0.94.4, 0.95.2
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Attachments: HBASE-7750-94.patch, HBASE-7750-trunk.patch
>
>
> It may be an expected behavior, but I think it's better to do something.
> We configured "hbase.replication" as true in master cluster, and added peer.
> But forgot to configure "hbase.replication" on slave cluster side.
> ReplicationSource read HLog, shipped log edits, and logged position.
> Everything seemed alright. But data was not present in slave cluster.
> So I think, slave cluster should throw exception to master cluster instead of
> return directly:
> {code}
> public void replicateLogEntries(final HLog.Entry[] entries)
> throws IOException {
> checkOpen();
> if (this.replicationSinkHandler == null) return;
> this.replicationSinkHandler.replicateLogEntries(entries);
> }
> {code}
> I would like to hear your comments on this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
