[ 
https://issues.apache.org/jira/browse/HBASE-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625592#comment-13625592
 ] 

ramkrishna.s.vasudevan commented on HBASE-7824:
-----------------------------------------------

waitingOnLogSplitting - waitOnLogSplitting may be better.
bq.this.catalogTracker.getMetaLocationOrReadLocationFromRoot();
Is it ok to call this in one place as per my yesterday's comment.
If root went down after 
{code}
this.initializationBeforeMetaAssignment = true;
{code}
we call assignRoot.  when we try to split the log we will not do that because 
SSH is not yet enabled.
{code}
    this.assignmentManager.assignRoot();
      waitForRootAssignment();
{code}
So we expect that though the above step waits, we do 
{code}
this.serverManager.enableSSHForRoot();
{code}
Which will do the assignment? Still sshEnabled is not true right?
Things look fine but still this area is really a big head ache.  Removal of 
ROOT in trunk is a blessing for developers now.
I think if you are confident on the above comments then let us go for a commit 
and address if future issues.  Else we are good.

Good stuff Jeff, Everytime I feel that something may be missed out in this area.
@Chunhui
What do you feel?

                
> Improve master start up time when there is log splitting work
> -------------------------------------------------------------
>
>                 Key: HBASE-7824
>                 URL: https://issues.apache.org/jira/browse/HBASE-7824
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>            Reporter: Jeffrey Zhong
>            Assignee: Jeffrey Zhong
>             Fix For: 0.94.8
>
>         Attachments: hbase-7824.patch, hbase-7824_v2.patch, 
> hbase-7824_v3.patch, hbase-7824-v7.patch, hbase-7824-v8.patch, 
> hbase-7824-v9.patch
>
>
> When there is log split work going on, master start up waits till all log 
> split work completes even though the log split has nothing to do with meta 
> region servers.
> It's a bad behavior considering a master node can run when log split is 
> happening while its start up is blocking by log split work. 
> Since master is kind of single point of failure, we should start it ASAP.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to