[ 
https://issues.apache.org/jira/browse/HBASE-3787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625995#comment-13625995
 ] 

Sergey Shelukhin commented on HBASE-3787:
-----------------------------------------

One point: assuming client doesn't retry across complete client failures (where 
client memory is lost), can we make the default nonce the atomically 
incrementing number? 
Fuzzy idea; client sends this int.
The server structure is - lower bound of operations per client that succeeded; 
list of operations that succeeded after that after some gaps in the sequence 
(or last nonce received from client + list of operations that failed and could 
be retries, and those that are in progress).
The lower bound moves up as operations succeed. Gaps are recycled after some 
time by a chore. WAL has the ID of the nonce + client ID, so that the structure 
could be restored after restarts.
Client has to change ID on restarts.
                
> Increment is non-idempotent but client retries RPC
> --------------------------------------------------
>
>                 Key: HBASE-3787
>                 URL: https://issues.apache.org/jira/browse/HBASE-3787
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.94.4, 0.95.2
>            Reporter: dhruba borthakur
>            Priority: Critical
>             Fix For: 0.95.1
>
>
> The HTable.increment() operation is non-idempotent. The client retries the 
> increment RPC a few times (as specified by configuration) before throwing an 
> error to the application. This makes it possible that the same increment call 
> be applied twice at the server.
> For increment operations, is it better to use 
> HConnectionManager.getRegionServerWithoutRetries()? Another  option would be 
> to enhance the IPC module to make the RPC server correctly identify if the 
> RPC is a retry attempt and handle accordingly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to