[ 
https://issues.apache.org/jira/browse/HBASE-8045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

rajeshbabu updated HBASE-8045:
------------------------------

    Attachment: HBASE-8045_3.patch

Thanks [~sershe] for review. Changed log and formatted code.

bq. Do we need to convert ZK data that stores location of meta?
IMO its not needed because when ever we assign .META. we are already writing PB 
serialized location to zk.
{code}
  static byte [] toByteArray(final ServerName sn) {
    // ZNode content is a pb message preceeded by some pb magic.
    HBaseProtos.ServerName pbsn =
      HBaseProtos.ServerName.newBuilder().setHostName(sn.getHostname()).
      setPort(sn.getPort()).setStartCode(sn.getStartcode()).build();
    ZooKeeperProtos.RootRegionServer pbrsr =
      ZooKeeperProtos.RootRegionServer.newBuilder().setServer(pbsn).build();
    return ProtobufUtil.prependPBMagic(pbrsr.toByteArray());
  }

{code}

                
> Fix .META. migration after HBASE-3171
> -------------------------------------
>
>                 Key: HBASE-8045
>                 URL: https://issues.apache.org/jira/browse/HBASE-8045
>             Project: HBase
>          Issue Type: Task
>            Reporter: Jean-Daniel Cryans
>            Priority: Blocker
>             Fix For: 0.95.1
>
>         Attachments: HBASE-8045_2.patch, HBASE-8045_3.patch, HBASE-8045.patch
>
>
> HBASE-3171 doesn't manage the migration correctly, see 
> MetaMigrationConvertingToPB and its unit test.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to