[ 
https://issues.apache.org/jira/browse/HBASE-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628283#comment-13628283
 ] 

Hadoop QA commented on HBASE-8316:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12578084/noencode.png
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5251//console

This message is automatically generated.
                
> JoinedHeap for non essential column families should reseek instead of seek
> --------------------------------------------------------------------------
>
>                 Key: HBASE-8316
>                 URL: https://issues.apache.org/jira/browse/HBASE-8316
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Filters, Performance, regionserver
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 0.98.0, 0.94.7, 0.95.1
>
>         Attachments: 8316-0.94.txt, 8316-trunk.txt, 8316-trunk.txt, 
> FDencode.png, noencode.png
>
>
> This was raised by the Phoenix team. During a profiling session we noticed 
> that catching the joinedHeap up to the current rows via seek causes a 
> performance regression, which makes the joinedHeap only efficient when either 
> a high or low percentage is matched by the filter.
> (High is fine, because the joinedHeap will not get behind as often and does 
> not need to be caught up, low is fine, because the seek isn't happening 
> frequently).
> In our tests we found that the solution is quite simple: Replace seek with 
> reseek. Patch coming soon.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to