[ 
https://issues.apache.org/jira/browse/HBASE-7704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628655#comment-13628655
 ] 

Ted Yu commented on HBASE-7704:
-------------------------------

In processTable():
{code}
+    for (Future<Path> f : regionLevelResults) {
+      try {
+        if (f.get() != null) {
+          regionsWithHFileV1.add(f.get());
+        }
+      } catch (InterruptedException e) {
+        System.err.println(e);
+      } catch (ExecutionException e) {
+        System.err.println(e); // might be a bad hfile. We print it at the end.
+      }
+    }
{code}
For ExecutionException, the print may be eclipsed by successive logs. I think 
we should store such error and print warning at the end.

Please also fix grammatical errors mentioned above.
                
> migration tool that checks presence of HFile V1 files
> -----------------------------------------------------
>
>                 Key: HBASE-7704
>                 URL: https://issues.apache.org/jira/browse/HBASE-7704
>             Project: HBase
>          Issue Type: Task
>            Reporter: Ted Yu
>            Assignee: Himanshu Vashishtha
>            Priority: Blocker
>             Fix For: 0.95.1
>
>         Attachments: HBase-7704-v1.patch, HBase-7704-v2.patch, 
> HBase-7704-v3.patch
>
>
> Below was Stack's comment from HBASE-7660:
> Regards the migration 'tool', or 'tool' to check for presence of v1 files, I 
> imagine it as an addition to the hfile tool 
> http://hbase.apache.org/book.html#hfile_tool2 The hfile tool already takes a 
> bunch of args including printing out meta. We could add an option to print 
> out version only – or return 1 if version 1 or some such – and then do a bit 
> of code to just list all hfiles and run this script against each. Could MR it 
> if too many files.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to