[
https://issues.apache.org/jira/browse/HBASE-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13629584#comment-13629584
]
Ted Yu commented on HBASE-1936:
-------------------------------
Minor comments for 0.94 patch :
{code}
+ } catch (InstantiationException e) {
+ throw new RuntimeException("Failed deserialize.", e);
+ } catch (IllegalAccessException e) {
+ throw new RuntimeException("Failed deserialize.", e);
{code}
Can we have better error message above ?
{code}
+ * Dynamic class loader to load filter/comparators
+ */
+ private final static ClassLoader CLASS_LOADER;
{code}
What if class loader for other purpose is introduced in the future ? Should the
above variable name be more specific ?
> ClassLoader that loads from hdfs; useful adding filters to classpath without
> having to restart services
> -------------------------------------------------------------------------------------------------------
>
> Key: HBASE-1936
> URL: https://issues.apache.org/jira/browse/HBASE-1936
> Project: HBase
> Issue Type: New Feature
> Reporter: stack
> Assignee: Jimmy Xiang
> Labels: noob
> Fix For: 0.98.0, 0.95.1
>
> Attachments: 0.94-1936.patch, cp_from_hdfs.patch,
> HBASE-1936-trunk(forReview).patch, trunk-1936.patch, trunk-1936_v2.1.patch,
> trunk-1936_v2.2.patch, trunk-1936_v2.patch, trunk-1936_v3.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
