[ 
https://issues.apache.org/jira/browse/HBASE-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13629850#comment-13629850
 ] 

Ted Yu commented on HBASE-8218:
-------------------------------

Thanks for the quick response.
{code}
+      this.threadPool.awaitTermination(Long.MAX_VALUE, TimeUnit.SECONDS);
{code}
Is the above waiting period too long ? How about waiting for 10 min ?
If awaitTermination() returns false, you should call this method:
http://docs.oracle.com/javase/6/docs/api/java/util/concurrent/ExecutorService.html#shutdownNow()

Please generate next patch from trunk so that hadoop QA can test the patch.
                
> pass HTable as a parameter to method of AggregationClient
> ---------------------------------------------------------
>
>                 Key: HBASE-8218
>                 URL: https://issues.apache.org/jira/browse/HBASE-8218
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client, Coprocessors
>    Affects Versions: 0.94.3
>            Reporter: cuijianwei
>         Attachments: HBASE-8218-0.94.3-v1.txt, HBASE-8218-0.94.3-v2.txt
>
>
> In AggregationClient, methods such as max(...), min(...) pass 'tableName' as 
> a parameter, then a HTable will be created in the method, before the method 
> return, the created HTable will be closed.
> The process above may be heavy because each call must create and close a 
> HTable. The situation becomes worse when there is only one thread access 
> HBase using AggregationClient. The underly HConnection of created HTable will 
> also be created and then closed each time when we invoke these method because 
> no other HTables using the HConnection. This operation is heavy. Therefore, 
> can we add another group of methods which pass HTable or HTablePool as a 
> parameter to methods defined in AggregationClient? 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to