[
https://issues.apache.org/jira/browse/HBASE-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13630625#comment-13630625
]
Enis Soztutar commented on HBASE-8333:
--------------------------------------
The analysis seems correct, but the patch does not fix the problem.
Master.deleteTable() runs in the handler thread, but we still do not wait for
it to complete. There is no easy way other than just sleeping to ensure that
the delete handler has completed. the second part of the patch seems good. It
fixes an unrelated problem though.
> TestTableLockManager#testDelete failed in trunk build #4056
> -----------------------------------------------------------
>
> Key: HBASE-8333
> URL: https://issues.apache.org/jira/browse/HBASE-8333
> Project: HBase
> Issue Type: Test
> Reporter: Ted Yu
> Assignee: Ted Yu
> Fix For: 0.98.0
>
> Attachments: 8333-v2.txt
>
>
> {code}
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at
> org.apache.hadoop.hbase.master.TestTableLockManager.testDelete(TestTableLockManager.java:250)
> {code}
> It corresponds to this assertion:
> {code}
> assertTrue(ZKUtil.checkExists(zkWatcher,
> ZKUtil.joinZNode(zkWatcher.tableLockZNode,
> Bytes.toString(TABLE_NAME))) < 0);
> {code}
> In test output
> (https://builds.apache.org/job/HBase-TRUNK/4056/testReport/junit/org.apache.hadoop.hbase.master/TestTableLockManager/testDelete/):
> {code}
> 2013-04-12 10:46:02,642 DEBUG
> [MASTER_TABLE_OPERATIONS-janus.apache.org,36265,1365763551669-0]
> handler.DeleteTableHandler(113): Table 'TestTableLevelLocks' archived!
> 2013-04-12 10:46:02,642 DEBUG
> [MASTER_TABLE_OPERATIONS-janus.apache.org,36265,1365763551669-0]
> handler.DeleteTableHandler(117): Removing 'TestTableLevelLocks' descriptor.
> 2013-04-12 10:46:02,643 DEBUG
> [MASTER_TABLE_OPERATIONS-janus.apache.org,36265,1365763551669-0]
> handler.DeleteTableHandler(121): Marking 'TestTableLevelLocks' as deleted.
> 2013-04-12 10:46:02,658 DEBUG
> [MASTER_TABLE_OPERATIONS-janus.apache.org,36265,1365763551669-0]
> master.TableLockManager$ZKTableLockManager$TableLockImpl(253): Attempt to
> release table write lock on :TestTableLevelLocks
> 2013-04-12 10:46:02,667 DEBUG
> [RS_CLOSE_META-janus.apache.org,54489,1365763551867-0] util.FSUtils(211):
> Creating
> file=hdfs://localhost:52497/user/jenkins/hbase/.META./1028785192/.tmp/59ec68e4587d43d6bc026e4d6f2aafa2
> with permission=rwxrwxrwx
> 2013-04-12 10:46:02,674 DEBUG
> [MASTER_TABLE_OPERATIONS-janus.apache.org,36265,1365763551669-0]
> lock.ZKInterProcessLockBase(297): Successfully released
> /hbase/table-lock/TestTableLevelLocks/write-master:362650000000002
> 2013-04-12 10:46:02,675 DEBUG
> [MASTER_TABLE_OPERATIONS-janus.apache.org,36265,1365763551669-0]
> master.TableLockManager$ZKTableLockManager$TableLockImpl(269): Released table
> lock on :TestTableLevelLocks
> {code}
> This seems to be timing issue: when admin.deleteTable(TABLE_NAME) returned,
> TableLockManager hadn't got around to finishing the release of table lock.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
