[
https://issues.apache.org/jira/browse/HBASE-8346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632398#comment-13632398
]
Hadoop QA commented on HBASE-8346:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12578824/HBase-8346-v1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/5320//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5320//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5320//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5320//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5320//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5320//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5320//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5320//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5320//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/5320//console
This message is automatically generated.
> Prefetchiing .META. rows in case only when useCache is set to true
> ------------------------------------------------------------------
>
> Key: HBASE-8346
> URL: https://issues.apache.org/jira/browse/HBASE-8346
> Project: HBase
> Issue Type: Bug
> Components: Client
> Affects Versions: 0.95.0
> Reporter: Himanshu Vashishtha
> Assignee: Himanshu Vashishtha
> Priority: Minor
> Attachments: HBase-8346-v1.patch
>
>
> While doing a .META. lookup (HCM#locateRegionInMeta), we also prefetch some
> other region's info for that table. The usual call to the meta lookup has
> useCache variable set to true.
> Currently, it calls preFetch irrespective of the value useCache flag:
> {code}
> if (Bytes.equals(parentTable, HConstants.META_TABLE_NAME) &&
> (getRegionCachePrefetch(tableName))) {
> prefetchRegionCache(tableName, row);
> }
> {code}
> Later on, if useCache flag is set to false, it deletes the entry for that row
> from the cache with a forceDeleteCachedLocation() call. This always results
> in two calls to the .META. table in this case. The useCache variable is set
> to false in case we are retrying to find a region (regionserver failover).
> It can be verified from the log statements of a client while having a
> regionserver failover. In the below example, the client was connected to
> a1217, when a1217 got killed. The region in question is moved to a1215.
> Client got this info from META scan, where as client cache this info from
> META, but then delete it from cache as it want the latest info.
> The result is even the meta provides the latest info, it is still deleted
> This causes even the latest info to be deleted. Thus, client deletes
> a1215.abc.com even though it is correct info.
> {code}
> 13/04/15 09:49:12 DEBUG client.HConnectionManager$HConnectionImplementation:
> Cached location for
> t,user7225973201630273569,1365536809331.40382355b8c45e1338d620c018f8ff6c. is
> a1217.abc.com:40020
> 13/04/15 09:49:12 WARN client.ServerCallable: Received exception, tries=1,
> numRetries=30 message=Connection refused
> 13/04/15 09:49:12 DEBUG client.HConnectionManager$HConnectionImplementation:
> Removed all cached region locations that map to
> a1217.abc.com,40020,1365621947381
> 13/04/15 09:49:13 DEBUG client.MetaScanner: Current INFO from scan results =
> {NAME =>
> 't,user7225973201630273569,1365536809331.40382355b8c45e1338d620c018f8ff6c.',
> STARTKEY => 'user7225973201630273569', ENDKEY => '', ENCODED =>
> 40382355b8c45e1338d620c018f8ff6c,}
> 13/04/15 09:49:13 DEBUG client.MetaScanner: Scanning .META. starting at
> row=t,user7225973201630273569,00000000000000 for max=10 rows using
> hconnection-0x7786df0f
> 13/04/15 09:49:13 DEBUG client.MetaScanner: Current INFO from scan results =
> {NAME =>
> 't,user7225973201630273569,1365536809331.40382355b8c45e1338d620c018f8ff6c.',
> STARTKEY => 'user7225973201630273569', ENDKEY => '', ENCODED =>
> 40382355b8c45e1338d620c018f8ff6c,}
> 13/04/15 09:49:13 DEBUG client.HConnectionManager$HConnectionImplementation:
> Cached location for
> t,user7225973201630273569,1365536809331.40382355b8c45e1338d620c018f8ff6c. is
> a1215.abc.com:40020
> 13/04/15 09:49:13 DEBUG client.HConnectionManager$HConnectionImplementation:
> Removed a1215.abc.com:40020 as a location of
> t,user7225973201630273569,1365536809331.40382355b8c45e1338d620c018f8ff6c. for
> tableName=t from cache
> 13/04/15 09:49:13 DEBUG client.MetaScanner: Current INFO from scan results =
> {NAME =>
> 't,user7225973201630273569,1365536809331.40382355b8c45e1338d620c018f8ff6c.',
> STARTKEY => 'user7225973201630273569', ENDKEY => '', ENCODED =>
> 40382355b8c45e1338d620c018f8ff6c,}
> 13/04/15 09:49:13 DEBUG client.HConnectionManager$HConnectionImplementation:
> Cached location for
> t,user7225973201630273569,1365536809331.40382355b8c45e1338d620c018f8ff6c. is
> a1215.abc.com:40020
> 13/04/15 09:49:13 WARN client.ServerCallable: Received exception, tries=2,
> numRetries=30
> message=org.apache.hadoop.hbase.exceptions.UnknownScannerException: Name:
> -6313340536390503703, already closed?
> 13/04/15 09:49:13 DEBUG client.ClientScanner: Advancing internal scanner to
> startKey at 'user760712450403198900'
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
