[ 
https://issues.apache.org/jira/browse/HBASE-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632673#comment-13632673
 ] 

Hudson commented on HBASE-8341:
-------------------------------

Integrated in hbase-0.95-on-hadoop2 #70 (See 
[https://builds.apache.org/job/hbase-0.95-on-hadoop2/70/])
    HBASE-8341 RestoreSnapshotHandler.prepare() is not called by 
SnapshotManager and TakeSnapshotHandler should first acquire the table lock 
(Revision 1468263)

     Result = FAILURE
enis : 
Files : 
* 
/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
* 
/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java
* 
/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java
* 
/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java

                
> RestoreSnapshotHandler.prepare() is not called by SnapshotManager  and 
> TakeSnapshotHandler should first acquire the table lock
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-8341
>                 URL: https://issues.apache.org/jira/browse/HBASE-8341
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 0.98.0, 0.95.1
>
>         Attachments: hbase-8341_v1.patch
>
>
> In HBASE-7848, we added table lock to enabled/disabled snapshot handlers, and 
> fixed SnapshotManager to call CloneSnapshotHandler.prepare() in HBASE-7957. 
> It seems that we overlooked the RestoreSnapshotHandler.prepare(). In this 
> issue we should fix that so that we acquire the table lock in restore 
> snapshot. 
> There is also a slightly related issue where TakeSnapshotHandler first loads 
> the HTD, then acquires the table lock. The order should be swapped to guard 
> against concurrent alter table statements. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to