[ 
https://issues.apache.org/jira/browse/HBASE-8355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13634296#comment-13634296
 ] 

Andrew Purtell edited comment on HBASE-8355 at 4/17/13 6:40 PM:
----------------------------------------------------------------

bq. We could use the context to do multiple outputs

I like handling this with the return slightly better but it's just personal 
taste, either option works. Shall I put up a patch for consideration? Do we 
care about backwards compatibility? (I argue no until we get this right, and 
also for removing the existing back compat added the last time we changed this 
hook for that reason -- or at least keeping only one back compat option.)
                
      was (Author: apurtell):
    bq. We could use the context to do multiple outputs

I like handling this with the return slightly better but it's just personal 
taste, either option works.
                  
> BaseRegionObserver#preCompactScannerOpen returns null
> -----------------------------------------------------
>
>                 Key: HBASE-8355
>                 URL: https://issues.apache.org/jira/browse/HBASE-8355
>             Project: HBase
>          Issue Type: Bug
>          Components: Coprocessors
>    Affects Versions: 0.98.0, 0.94.8, 0.95.1
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>         Attachments: 8355-0.94.patch, 8355.patch
>
>
> As pointed out in https://github.com/forcedotcom/phoenix/pull/131, 
> BaseRegionObserver#preCompactScannerOpen returns null by default, which hoses 
> any coprocessors down the line, making override of this method mandatory. The 
> fix is trivial, patch coming momentarily.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to