[ 
https://issues.apache.org/jira/browse/HBASE-8366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13634449#comment-13634449
 ] 

Himanshu Vashishtha commented on HBASE-8366:
--------------------------------------------

Along with this, it also prints response which sometimes is quite large. 
HBaseServer#setResponse:
{code}
        if (LOG.isDebugEnabled()) {
          LOG.debug("Header " + TextFormat.shortDebugString(header) +
            ", result " + (result != null? TextFormat.shortDebugString(result): 
"null"));
        }
{code}
This bloats the log file, usually unnecessary. Reading the TextFormat code 
doesn't tell me we are really shortening the response size. It should rather be 
a trace level, or let's just print the header and move result to trace level.
                
> HBaseServer logs the full query.
> --------------------------------
>
>                 Key: HBASE-8366
>                 URL: https://issues.apache.org/jira/browse/HBASE-8366
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.95.0
>            Reporter: Nicolas Liochon
>            Assignee: Nicolas Liochon
>             Fix For: 0.98.0, 0.95.1
>
>         Attachments: 8366.v1.patch
>
>
> We log the query when we have an error. As a results, the logs are not 
> readable when using stuff like multi.
> As a side note, this is as well a security issue (no need to encrypt the 
> network and the storage if the logs contain everything). I'm not removing the 
> full log line here; but just ask and I do it :-).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to