[
https://issues.apache.org/jira/browse/HBASE-7006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13637026#comment-13637026
]
Ted Yu commented on HBASE-7006:
-------------------------------
For ReplicationZookeeper.java :
{code}
+ public static byte[] toByteArray(
+ final long position) {
{code}
Considering lockToByteArray() method that follows above, maybe rename above as
positionToByteArray()
{code}
+ public static final String REGION_ASSIGNMENT_TIME_OUT =
"hbase.master.region.assignment.time.out";
{code}
How about "hbase.master.region.assignment.timeout" ?
{code}
+ static final String REPLAY_BATCH_SIZE_DESC = "Number of changes of each
replay batch.";
{code}
""Number of changes of each" -> ""Number of changes in each"
For AssignmentManager.java :
{code}
+ long end = (timeOut <= 0) ? Long.MAX_VALUE : System.currentTimeMillis() +
timeOut;
...
+ if (System.currentTimeMillis() > end) {
{code}
Please use EnvironmentEdge.
> [MTTR] Study distributed log splitting to see how we can make it faster
> -----------------------------------------------------------------------
>
> Key: HBASE-7006
> URL: https://issues.apache.org/jira/browse/HBASE-7006
> Project: HBase
> Issue Type: Bug
> Components: MTTR
> Reporter: stack
> Assignee: Jeffrey Zhong
> Priority: Critical
> Fix For: 0.95.1
>
> Attachments: hbase-7006-combined.patch, LogSplitting Comparison.pdf,
> ProposaltoimprovelogsplittingprocessregardingtoHBASE-7006-v2.pdf
>
>
> Just saw interesting issue where a cluster went down hard and 30 nodes had
> 1700 WALs to replay. Replay took almost an hour. It looks like it could run
> faster that much of the time is spent zk'ing and nn'ing.
> Putting in 0.96 so it gets a look at least. Can always punt.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
