[
https://issues.apache.org/jira/browse/HBASE-8393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13638738#comment-13638738
]
Hadoop QA commented on HBASE-8393:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12579960/hbase-8393.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.security.access.TestAccessController
org.apache.hadoop.hbase.master.TestTableLockManager
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/5388//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5388//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5388//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5388//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5388//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5388//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5388//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5388//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5388//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/5388//console
This message is automatically generated.
> Testcase TestHeapSize#testMutations is wrong
> --------------------------------------------
>
> Key: HBASE-8393
> URL: https://issues.apache.org/jira/browse/HBASE-8393
> Project: HBase
> Issue Type: Bug
> Components: test
> Reporter: Jeffrey Zhong
> Assignee: Jeffrey Zhong
> Attachments: hbase-8393.patch
>
>
> I happened to check this test case and there are several existing errors to
> make it pass. You can reproduce the test case failure by adding a new field
> into Mutation, the test case will either fail on a 64 bit system or 32 bit
> one.
> Below are errors I found in the test case:
> 1) The test case is using {code}row=new byte[]{0}{code} which is an array
> with length=1 while ClassSize.estimateBase can only calculate base class
> size(without counting field array length)
> 2) Add ClassSize.REFERENCE twice in the following code because
> ClassSize.estimateBase adds all reference fields already. {code}expected +=
> ClassSize.align(ClassSize.TREEMAP + ClassSize.REFERENCE);{code}
> 3) ClassSize.estimateBase round up the sum of length of reference fields +
> primitive fields + Array while Mutation.MUTATION_OVERHEAD aligns the sum of
> length of a different set of fields. Therefore, there will be round up
> differences for class Increment because it introduces a new reference field
> TimeRange tr when the test case runs on a 32bit and 64 bit system.
> {code}
> ...
> long prealign_size = coeff[0] + align(coeff[1] * ARRAY) + coeff[2] *
> REFERENCE;
> // Round up to a multiple of 8
> long size = align(prealign_size);
> ...
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
