[
https://issues.apache.org/jira/browse/HBASE-8397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13639218#comment-13639218
]
Ivan A. Veselovsky commented on HBASE-8397:
-------------------------------------------
Hi, Elliot,
in this case we actually don't wait for anything with sleep(). Here we just
need to have the time between 2 invocations of masterMetrics.doUpdates() to be
greater or equal than 1 second, otherwise we cannot get non-zero metric rate
value. The most straight and simple way to achieve this is Thread.sleep(1000).
Sure, I can substitute that with while/sleep, but why that is better?
Timeout on the test can also be added, but in this case it seems that there is
no real opportunity to hang up.
> improve unit-test coverage of package org.apache.hadoop.hbase.master.metrics
> (0.94)
> -----------------------------------------------------------------------------------
>
> Key: HBASE-8397
> URL: https://issues.apache.org/jira/browse/HBASE-8397
> Project: HBase
> Issue Type: Test
> Affects Versions: 0.94.8
> Reporter: Ivan A. Veselovsky
> Attachments: HBASE-8397-0.94--N3.patch, HBASE-8397-0.94--N5.patch
>
>
> The patch suggests new test that elevates unit-test coverage of package
> org.apache.hadoop.hbase.master.metrics .
> The patch is applicable to branch 0.94 only.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
