[ 
https://issues.apache.org/jira/browse/HBASE-8299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13639279#comment-13639279
 ] 

Sergey Shelukhin commented on HBASE-8299:
-----------------------------------------

bq. This class will search all possibilities for different 
unfinished

bq. .subList(0, Math.max(0,candidateSelection.size() - 1 - 
comConf.getMinFilesToCompact()))
subList's 2nd argument is exclusive, so -1 is not needed as far as I see. E.g. 
5 files, 3 min files, will now remove [0, 1), leaving 4 files not 3.
I think test is needed for this path.

bq. //To change body of implemented methods use File | Settings | File 
Templates.
Leftovers.

There are long lines.
                
> ExploringCompactionPolicy can get stuck in rare cases.
> ------------------------------------------------------
>
>                 Key: HBASE-8299
>                 URL: https://issues.apache.org/jira/browse/HBASE-8299
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.95.1
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>         Attachments: HBASE-8299-0.patch, HBASE-8299-1.patch, 
> HBASE-8299-2.patch
>
>
> If the files are very oddly sized then it's possible that 
> ExploringCompactionPolicy can get stuck.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to