[
https://issues.apache.org/jira/browse/HBASE-5946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13639894#comment-13639894
]
Hadoop QA commented on HBASE-5946:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12580171/HBASE-5946.diff
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces lines longer than
100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/5419//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5419//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5419//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5419//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5419//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5419//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5419//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5419//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5419//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/5419//console
This message is automatically generated.
> Thrift Filter Language documentation is inconsistent
> ----------------------------------------------------
>
> Key: HBASE-5946
> URL: https://issues.apache.org/jira/browse/HBASE-5946
> Project: HBase
> Issue Type: Bug
> Components: Filters, Thrift
> Affects Versions: 0.92.1
> Reporter: Alexander
> Priority: Minor
> Labels: filter, php, thrift
> Attachments: HBASE-5946.diff
>
>
> Syntax: SingleColumnValueFilter(<compare operator>, '<comparator>',
> '<family>', '<qualifier>), as described here:
> http://hbase.apache.org/book/thrift.html is not correct.
> The correct syntax is: SingleColumnValueFilter('<family>', '<qualifier>',
> <compare operator>, '<comparator>')
> Also, <comparator> parameter must always contain the comparator, e.g. binary:
> or binaryprefix: etc. Without it (except PrefixFilter and maybe some other
> filters) TSocket class throws TTransportException: TSocket read 0 bytes.
> All examples in section 9.3.1.9. Individual Filter Syntax are written without
> comparator.
> There also a typo:
> in section 9.3.1.9.12 - Family Filter, syntax and example described for
> QualifierFilter
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira