[
https://issues.apache.org/jira/browse/HBASE-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13641286#comment-13641286
]
cuijianwei commented on HBASE-8218:
-----------------------------------
@Anoop, thanks for your idear, users have to call the close() method using the
current patch. This is not good enough to be compatible with the old code. From
this aspect, overloading APIs seems better, @Ted, @JM, what do you think about
this?
> Pass HConnection and ExecutorService as parameters to methods of
> AggregationClient
> ----------------------------------------------------------------------------------
>
> Key: HBASE-8218
> URL: https://issues.apache.org/jira/browse/HBASE-8218
> Project: HBase
> Issue Type: Improvement
> Components: Client, Coprocessors
> Affects Versions: 0.94.3
> Reporter: cuijianwei
> Assignee: cuijianwei
> Fix For: 0.98.0
>
> Attachments: 8218-trunk-v2-rerun.txt, 8218-trunk-v2.txt,
> 8218-trunk-v3-rerun.txt, 8218-trunk-v3.txt, HBASE-8218-0.94.3-v1.txt,
> HBASE-8218-0.94.3-v2.txt, HBASE-8218-0.94.3-v3.txt, HBASE-8218-trunk-v1.txt
>
>
> In AggregationClient, methods such as max(...), min(...) pass 'tableName' as
> a parameter, then a HTable will be created in the method, before the method
> return, the created HTable will be closed.
> The process above may be heavy because each call must create and close a
> HTable. The situation becomes worse when there is only one thread access
> HBase using AggregationClient. The underly HConnection of created HTable will
> also be created and then closed each time when we invoke these method because
> no other HTables using the HConnection. This operation is heavy. Therefore,
> can we add another group of methods which pass HTable or HTablePool as a
> parameter to methods defined in AggregationClient?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
