[
https://issues.apache.org/jira/browse/HBASE-5930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13641356#comment-13641356
]
Lars Hofhansl commented on HBASE-5930:
--------------------------------------
Why is the approach in the patch better than what I have described?
I believe the approach I described is better in the following ways:
* The logic is simpler
* We directly measure the age of oldest edit in the memstore, which is the
exact metric we want to limit
* We only have track the current time for the first KV inserted into the
memstore after a flush (System.currentTimeMillis() is not free)
I'm happy to make a sample patch, then we can decide on the merit of the two
patches.
> Periodically flush the Memstore?
> --------------------------------
>
> Key: HBASE-5930
> URL: https://issues.apache.org/jira/browse/HBASE-5930
> Project: HBase
> Issue Type: Improvement
> Reporter: Lars Hofhansl
> Assignee: Devaraj Das
> Priority: Minor
> Fix For: 0.95.1
>
> Attachments: 5930-1.patch, 5930-2.1.patch, 5930-2.2.patch,
> 5930-2.3.patch, 5930-2.4.patch, 5930-wip.patch
>
>
> A colleague of mine ran into an interesting issue.
> He inserted some data with the WAL disabled, which happened to fit in the
> aggregate Memstores memory.
> Two weeks later he a had problem with the HDFS cluster, which caused the
> region servers to abort. He found that his data was lost. Looking at the log
> we found that the Memstores were not flushed at all during these two weeks.
> Should we have an option to flush memstores periodically. There are obvious
> downsides to this, like many small storefiles, etc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
