[ https://issues.apache.org/jira/browse/HBASE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645571#comment-13645571 ]
Ted Yu commented on HBASE-8465: ------------------------------- bq. make this a runtime restore snapshot parameter instead of a xml configuration option? I thought adding a new 'rollback auto-drop' config parameter facilitates back compatibility. > Auto-drop rollback snapshot for snapshot restore > ------------------------------------------------ > > Key: HBASE-8465 > URL: https://issues.apache.org/jira/browse/HBASE-8465 > Project: HBase > Issue Type: Improvement > Reporter: Ted Yu > Assignee: Ted Yu > > Below is an excerpt from snapshot restore javadoc: > {code} > * Restore the specified snapshot on the original table. (The table must be > disabled) > * Before restoring the table, a new snapshot with the current table state > is created. > * In case of failure, the table will be rolled back to the its original > state. > {code} > We can improve the handling of rollbackSnapshot in two ways: > 1. give better name to the rollbackSnapshot (adding > {code}'-for-rollback-'{code}). Currently the name is of the form: > String rollbackSnapshot = snapshotName + "-" + > EnvironmentEdgeManager.currentTimeMillis(); > 2. drop rollbackSnapshot at the end of restoreSnapshot() if the restore is > successful. We can introduce new config param, named > 'hbase.snapshot.restore.drop.rollback', to keep compatibility with current > behavior. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira