[ 
https://issues.apache.org/jira/browse/HBASE-8460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645930#comment-13645930
 ] 

Jean-Daniel Cryans commented on HBASE-8460:
-------------------------------------------

bq. Is trying to copy our own queues a valid condition, configuration/user 
error, or a bug? Should it be logged, or throw, if it's one of the latter?

It might be a good thing to log, considering it would have on the notification 
that your own ephemeral znode was deleted (meaning you lost your session).

+1 after fixing the other things Sergey saw.
                
> [replication] Fix the three TODOs in 
> TestReplicationStateBasic.testReplicationQueues
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-8460
>                 URL: https://issues.apache.org/jira/browse/HBASE-8460
>             Project: HBase
>          Issue Type: Bug
>          Components: Replication
>            Reporter: Chris Trezzo
>            Assignee: Chris Trezzo
>            Priority: Minor
>             Fix For: 0.95.1
>
>         Attachments: HBASE-8460-trunk-v1.patch
>
>
> There are three TODO's in TestReplicationStateBasic.testReplicationQueues.
> 1. Possible NPE when getLogPosition is called on a Bogus HLog file.
> 2. The assertion that tested setting a log position on a bogus file was 
> commented out.
> 3. When claimQueues is given the regionserver znode for itself, it will try 
> to copy its own queues.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to