[ 
https://issues.apache.org/jira/browse/HBASE-8492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13650167#comment-13650167
 ] 

Andrew Purtell commented on HBASE-8492:
---------------------------------------

We should be hesitant to change a unit test that has a lot of cases and has had 
flaky test fixes in the past. Why start mucking around and destabilize it again?

bq. This way, stopping the active master and letting standby master take over 
would happen only once instead of for every test.

-1, this is why I suggest a separate unit test. Leave TestAccessController 
alone.
                
> Introduce master failover into TestAccessController
> ---------------------------------------------------
>
>                 Key: HBASE-8492
>                 URL: https://issues.apache.org/jira/browse/HBASE-8492
>             Project: HBase
>          Issue Type: Test
>            Reporter: Ted Yu
>         Attachments: 8492-0.94-v1.txt
>
>
> Currently TestAccessController starts a cluster with one master.
> This JIRA introduces two masters in the cluster where the active master is 
> stopped. Expectation is that standby master should take over and perform 
> permission verification.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to