[ 
https://issues.apache.org/jira/browse/HBASE-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13650405#comment-13650405
 ] 

ramkrishna.s.vasudevan commented on HBASE-7897:
-----------------------------------------------

bq.Maybe change getTagsArray() to be plural like the other two?
Ok will do that.
bq.If we did want to have a getNumTags(), we'd probably want to store numTags 
as a VInt somewhere in the cell.
This is what i have done currently in my implementation.  Not as a Vint but a 
single byte.
So i thought having getNumTags() would be meaningful.  If we don't have this 
then we should every time use some way to find out the number of tags given the 
tagByteArray.
But as you said just to know if a Cell has tags or not getTagsLength() > 0 
should help.

                
> Add support for tags to Cell Interface
> --------------------------------------
>
>                 Key: HBASE-7897
>                 URL: https://issues.apache.org/jira/browse/HBASE-7897
>             Project: HBase
>          Issue Type: Task
>            Reporter: stack
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Critical
>             Fix For: 0.95.1
>
>         Attachments: HBASE-7897_1.patch, HBASE-7897_2.patch, HBASE-7897.patch
>
>
> Cell Interface has suppport for mvcc.   The only thing we'd add to Cell in 
> the near future is support for tags it would seem.  Should be easy to add.  
> Should add it now.  See backing discussion here: 
> https://issues.apache.org/jira/browse/HBASE-7233?focusedCommentId=13573784&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13573784
> Matt outlines what the additions to Cell might look like here:
> https://issues.apache.org/jira/browse/HBASE-7233?focusedCommentId=13531619&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13531619
> Would be good to get these in now.
> Marking as 0.96.  Can more later.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to