[ 
https://issues.apache.org/jira/browse/HBASE-7932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13652426#comment-13652426
 ] 

stack commented on HBASE-7932:
------------------------------

I was going off the TODO comment here and the call on the end where it does 
updateMetaWithFavoredNodesInfo

{code}
+  // TODO: processFavoredNodes might throw an exception, for e.g., if the 
+  // meta could not be contacted/updated. We need to see how seriously to treat
+  // this problem as. Should we fail the current assignment. We should be able
+  // to recover from this problem eventually (if the meta couldn't be updated
+  // things should work normally and eventually get fixed up).
+  void processFavoredNodes(List<HRegionInfo> regions) throws IOException {
+    if (!shouldAssignRegionsWithFavoredNodes) return;
+    // The AM gets the favored nodes info for each region and updates the meta
+    // table with that info
+    Map<HRegionInfo, List<ServerName>> regionToFavoredNodes =
+        new HashMap<HRegionInfo, List<ServerName>>();
+    for (HRegionInfo region : regions) {
+      regionToFavoredNodes.put(region, 
+          ((FavoredNodeLoadBalancer)this.balancer).getFavoredNodes(region));
+    }
+    
FavoredNodeLoadBalancer.updateMetaWithFavoredNodesInfo(regionToFavoredNodes, 
catalogTracker);
+  }
{code}


If not extra calls to meta, great.
                
> Do the necessary plumbing for the region locations in META table and send the 
> info to the RegionServers
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7932
>                 URL: https://issues.apache.org/jira/browse/HBASE-7932
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>            Priority: Critical
>             Fix For: 0.95.1
>
>         Attachments: 7932-1.patch, 7932-3.patch, 7932-8.1.patch, 
> 7932-8.patch, 7932-simple-2.patch, 7932-simple-with-meta-pb.1.txt, 
> 7932-simple-with-meta-pb.2.txt, 7932-wip-2.patch, 7932-wip-3.patch, 
> 7932-wip-4.patch, 7932-wip.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to