[ 
https://issues.apache.org/jira/browse/HBASE-8516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13653128#comment-13653128
 ] 

Sergey Shelukhin commented on HBASE-8516:
-----------------------------------------

Patch looks good. There's javadoc warning though
                
> FSUtils.create() fail with ViewFS
> ---------------------------------
>
>                 Key: HBASE-8516
>                 URL: https://issues.apache.org/jira/browse/HBASE-8516
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.94.7, 0.95.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Trivial
>             Fix For: 0.98.0, 0.94.8, 0.95.2
>
>         Attachments: HBASE-8516.patch
>
>
> FSUtils.create() and SequenceFileLogWriter are using 
> fs.getDefaultReplication() and fs.getDefaultBlockSize() which is deprecated 
> and in case of ViewFS throws an exception. replace that with the 
> fs.getDefault*(path)
> {code}
> @Override
> public long getDefaultBlockSize() {
>   throw new NotInMountpointException("getDefaultBlockSize");
> }
> @Override
> public short getDefaultReplication() {
>   throw new NotInMountpointException("getDefaultReplication");
> }
> {code}
> {noformat}
> exception in thread "main" 
> org.apache.hadoop.fs.viewfs.NotInMountpointException: getDefaultReplication 
> on empty path is invalid
>       at 
> org.apache.hadoop.fs.viewfs.ViewFileSystem.getDefaultReplication(ViewFileSystem.java:508)
>       at org.apache.hadoop.hbase.util.FSUtils.create(FSUtils.java:156)
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to