[ 
https://issues.apache.org/jira/browse/HBASE-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13654680#comment-13654680
 ] 

Jeffrey Zhong commented on HBASE-8154:
--------------------------------------

A minor comment since it's a public utility method, it'd be better that we can 
put the retry logic inside the function like 
"startMiniDFSClusterForTestHLog(int namenodePort, int retries)" so new client 
code won't do the same when calling the function.

Other than that +1 from me! Thanks.
                
> HBaseTestingUtility.startMiniDFSClusterForTestHLog should handle "Address 
> already in use" and retry automatically
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-8154
>                 URL: https://issues.apache.org/jira/browse/HBASE-8154
>             Project: HBase
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.98.0
>            Reporter: Liang Xie
>            Assignee: Ted Yu
>         Attachments: 8154-v2.txt, 8154-v3.txt
>
>
> see 
> https://builds.apache.org/job/PreCommit-HBASE-Build/4906//testReport/org.apache.hadoop.hbase.regionserver.wal/TestHLog/testAppendClose/
> and 
> https://issues.apache.org/jira/browse/HBASE-7845?focusedCommentId=13607468&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13607468

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to