[
https://issues.apache.org/jira/browse/HBASE-8527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13655065#comment-13655065
]
Ted Yu commented on HBASE-8527:
-------------------------------
{code}
- } finally {
- // We need the lock, as long as we are updating the storeFiles
- // or changing the memstore. Let us release it before calling
- // notifyChangeReadersObservers. See HBASE-4485 for a possible
- // deadlock scenario that could have happened if continue to hold
- // the lock.
- this.lock.writeLock().unlock();
{code}
I see the this.lock.writeLock().unlock() call is moved. Better move the comment
as well.
> clean up code around compaction completion in HStore
> ----------------------------------------------------
>
> Key: HBASE-8527
> URL: https://issues.apache.org/jira/browse/HBASE-8527
> Project: HBase
> Issue Type: Improvement
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Priority: Minor
> Attachments: HBASE-8527-v0.patch
>
>
> The methods completeCompaction and it's caller are too long. Something I
> changed while doing something else there; putting in a separate
> easy-to-review JIRA to make the other future change smaller.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
