[
https://issues.apache.org/jira/browse/HBASE-8530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13655266#comment-13655266
]
Matteo Bertozzi commented on HBASE-8530:
----------------------------------------
+1 for me
just to make more context for the jira...
If a snapshot is in .tmp it may be in-progress after an "HBaseAdmin.snapshot()"
operation, or an export may be in-progress.
The "consider removing /hbase/.hbase-snapshot/SNAPSHOT_NAME directory" should
never happen since the the temp folder is removed in case of snapshot/export
failure... so it may be there only if the fs.delete() operation fails.
> Refine error message from ExportSnapshot when there is leftover snapshot in
> target cluster
> ------------------------------------------------------------------------------------------
>
> Key: HBASE-8530
> URL: https://issues.apache.org/jira/browse/HBASE-8530
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Minor
> Fix For: 0.98.0
>
> Attachments: 8530-v1.txt
>
>
> ExportSnapshot performs the following validation check before starting export:
> {code}
> // Check if the snapshot already in-progress
> if (outputFs.exists(snapshotTmpDir)) {
> System.err.println("A snapshot with the same name '" + snapshotName +
> "' is in-progress");
> return 1;
> }
> {code}
> The intention was to prevent concurrent snapshot export when snapshot with
> the same name may be outstanding.
> Here is sample output:
> {code}
> hbase@ip-10-165-36-226 root$ hbase
> org.apache.hadoop.hbase.snapshot.ExportSnapshot -snapshot snapone -copy-to
> hdfs://10.12.113.22:8020/apps/hbase/data -mappers 1
> A snapshot with the same name 'snapone' is in-progress
> {code}
> We should note the actual path in the error message so that user can check
> whether the snapshot with same name is still pending.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira