[
https://issues.apache.org/jira/browse/HBASE-8353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
rajeshbabu updated HBASE-8353:
------------------------------
Attachment: HBASE-8353_94_4.patch
In M_ZK_REGION_OFFLINE case region should be assigned in any case whether
target server is online or not instead of waiting for TM.
So removed unnecessary checks while processing M_ZK_REGION_OFFLINE node and
directly calling assign through ClosedRegionHandler.
{code}
// Region is offline, insert into RIT and handle it like a closed
addToRITandCallClose(regionInfo, RegionState.State.OFFLINE, data);
{code}
bq.HAve you tested this in a cluster?
I will test all the scenarios including rolling restart tomorrow morning IST
and let you know.
bq.Also if the any region is on dead RS it will be forced to OFFLINE and not
only the ROOT and META?
Yes, It will be forced to OFFLINE and assign.
Thanks for review Ram.
> -ROOT-/.META. regions are hanging if master restarted while closing
> -ROOT-/.META. regions on dead RS
> ----------------------------------------------------------------------------------------------------
>
> Key: HBASE-8353
> URL: https://issues.apache.org/jira/browse/HBASE-8353
> Project: HBase
> Issue Type: Bug
> Components: Region Assignment
> Affects Versions: 0.94.6
> Reporter: rajeshbabu
> Assignee: rajeshbabu
> Fix For: 0.94.8
>
> Attachments: HBASE-8353_94_2.patch, HBASE-8353_94_3.patch,
> HBASE-8353_94_4.patch, HBASE-8353_94.patch
>
>
> ROOT/META are not getting assigned if master restarted while closing
> ROOT/META.
> Lets suppose catalog table regions in M_ZK_REGION_CLOSING state during master
> initialization and then just we are adding the them to RIT and waiting for
> TM. {code}
> if (isOnDeadServer(regionInfo, deadServers) &&
> (data.getOrigin() == null ||
> !serverManager.isServerOnline(data.getOrigin()))) {
> // If was on dead server, its closed now. Force to OFFLINE and this
> // will get it reassigned if appropriate
> forceOffline(regionInfo, data);
> } else {
> // Just insert region into RIT.
> // If this never updates the timeout will trigger new assignment
> regionsInTransition.put(encodedRegionName, new RegionState(
> regionInfo, RegionState.State.CLOSING,
> data.getStamp(), data.getOrigin()));
> }
> {code}
> isOnDeadServer always return false to ROOT/META because deadServers is null.
> Even TM cannot close them properly because its not available in online
> regions since its not yet assigned.
> {code}
> synchronized (this.regions) {
> // Check if this region is currently assigned
> if (!regions.containsKey(region)) {
> LOG.debug("Attempted to unassign region " +
> region.getRegionNameAsString() + " but it is not " +
> "currently assigned anywhere");
> return;
> }
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
