[
https://issues.apache.org/jira/browse/HBASE-8471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13662242#comment-13662242
]
Hadoop QA commented on HBASE-8471:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12583856/HBASE-8471.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces lines longer than
100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.hbase.master.TestAssignmentManager.testSSHTimesOutOpeningRegionTransition(TestAssignmentManager.java:967)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/5754//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5754//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5754//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5754//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5754//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5754//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5754//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5754//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5754//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/5754//console
This message is automatically generated.
> Server-side, remove convertion from pb type to client type before we call
> method
> --------------------------------------------------------------------------------
>
> Key: HBASE-8471
> URL: https://issues.apache.org/jira/browse/HBASE-8471
> Project: HBase
> Issue Type: Improvement
> Components: IPC/RPC, regionserver
> Affects Versions: 0.95.0
> Reporter: stack
> Assignee: Anoop Sam John
> Priority: Critical
> Attachments: HBASE-8471.patch, HBASE-8471.patch
>
>
> In the regionserver, when the rpc receives a call, the call is described
> using protobufs. Before we make the server-side invocation, we do a
> transform on the pb param objects to make a native pojo -- e.g. from a pb
> Puts into an hbase o.a.h.h.client.Put -- and only then do we make the call
> against the server.
> On the way out, similar, before putting the result on the wire, we will do a
> convertion from o.a.h.h.client.Result into pb Result.
> This issue is about our first INVESTIGATING if it is possible to do away w/
> this marshalling/unmarshalling serverside especially given the pb objects
> themselves are rich in accessor and getters, etc. If it is possible to do w/
> pbs alone serverside, then we should go ahead and rip out all the serverside
> convertions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
