[
https://issues.apache.org/jira/browse/HBASE-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13662610#comment-13662610
]
Enis Soztutar commented on HBASE-8582:
--------------------------------------
This is interesting. The assumption in visitLocks was that we won't get null
from listChildren since we were expecting the parent znode to be there. It will
only be deleted or non-existent if the table is deleted. But I guess hbck can
run into those kind of cases, so patch is good.
> Possible NullPointerException in ZKInterProcessLockBase#visitLocks
> ------------------------------------------------------------------
>
> Key: HBASE-8582
> URL: https://issues.apache.org/jira/browse/HBASE-8582
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Fix For: 0.98.0, 0.95.1
>
> Attachments: 8582-v1.txt
>
>
> Running test suite on hadoop 2.0 I saw the following test failure:
> {code}
> testErrorReporter(org.apache.hadoop.hbase.util.TestHBaseFsck) Time elapsed:
> 0.003 sec <<< ERROR!
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.zookeeper.lock.ZKInterProcessLockBase.visitLocks(ZKInterProcessLockBase.java:426)
> at
> org.apache.hadoop.hbase.master.TableLockManager$ZKTableLockManager.visitAllLocks(TableLockManager.java:386)
> at
> org.apache.hadoop.hbase.util.hbck.TableLockChecker.checkTableLocks(TableLockChecker.java:76)
> at
> org.apache.hadoop.hbase.util.HBaseFsck.checkAndFixTableLocks(HBaseFsck.java:2480)
> at
> org.apache.hadoop.hbase.util.HBaseFsck.onlineHbck(HBaseFsck.java:460)
> at
> org.apache.hadoop.hbase.util.hbck.HbckTestingUtil.doFsck(HbckTestingUtil.java:65)
> at
> org.apache.hadoop.hbase.util.hbck.HbckTestingUtil.doFsck(HbckTestingUtil.java:41)
> at
> org.apache.hadoop.hbase.util.hbck.HbckTestingUtil.doFsck(HbckTestingUtil.java:36)
> at
> org.apache.hadoop.hbase.util.TestHBaseFsck.testErrorReporter(TestHBaseFsck.java:1868)
> {code}
> Here is related code:
> {code}
> public void visitLocks(MetadataHandler handler) throws IOException {
> List<String> children;
> try {
> children = ZKUtil.listChildrenNoWatch(zkWatcher, parentLockNode);
> {code}
> Looks like children was null.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
