[
https://issues.apache.org/jira/browse/HBASE-8597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13666492#comment-13666492
]
Hadoop QA commented on HBASE-8597:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12584706/8597-v2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/5819//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5819//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5819//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5819//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5819//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5819//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5819//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5819//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/5819//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/5819//console
This message is automatically generated.
> compaction record (probably) can block WAL cleanup forever if region is
> closed without edits
> --------------------------------------------------------------------------------------------
>
> Key: HBASE-8597
> URL: https://issues.apache.org/jira/browse/HBASE-8597
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.95.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Priority: Blocker
> Fix For: 0.95.1
>
> Attachments: 8597-v2.patch, HBASE-8597-v0.patch, HBASE-8597-v1.patch
>
>
> A region is opened by a server, major compaction is performed, that triggers
> a split, and the region is closed and split. There's no indication of
> memstore flush for this region.
> After that, LogRoller repeatedly tries to request the flush of this region
> due to large number of HLogs, but fails to flush it for hours because the
> region is not in online regions.
> It seems that what's happening is that when we append entries to WAL we add
> the first entry after we flush/open some region to "earliest unflushed
> seqNums per region" map in FSHLog. However, compaction now adds compaction
> record to WAL, which also affects this map. If the compaction record is the
> first entry for this region to go into some WAL, and there are no writes to
> the region after that, there will be no memstore flush and the entry will
> never be removed.
> In fact "flushing" for compaction record doesn't make sense, there's no
> preservation of the record outside WAL; so, we probably should not add it to
> "latest unflushed" map.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
