[ 
https://issues.apache.org/jira/browse/HBASE-8366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13666710#comment-13666710
 ] 

Andrew Purtell commented on HBASE-8366:
---------------------------------------

Looks good to me.

> +   * Return short version of Message toString'd, shorter than 
> TextFormat#regionServerStartup.

Probably you want TextFormat#shortDebugString there.

> +    return "TODO: " + m.getClass().toString();

I like this rather than a fall back to something that could spew.


                
> HBaseServer logs the full query.
> --------------------------------
>
>                 Key: HBASE-8366
>                 URL: https://issues.apache.org/jira/browse/HBASE-8366
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.95.0
>            Reporter: Nicolas Liochon
>            Assignee: stack
>            Priority: Critical
>             Fix For: 0.98.0, 0.95.1
>
>         Attachments: 8366.txt, 8366.v1.patch, 8366v2.txt
>
>
> We log the query when we have an error. As a results, the logs are not 
> readable when using stuff like multi.
> As a side note, this is as well a security issue (no need to encrypt the 
> network and the storage if the logs contain everything). I'm not removing the 
> full log line here; but just ask and I do it :-).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to