[
https://issues.apache.org/jira/browse/HBASE-8611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13668690#comment-13668690
]
Nick Dimiduk commented on HBASE-8611:
-------------------------------------
Read through trunk-b.patch, looks good. Ran these tests on trunk, here's the
output:
{noformat}
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.hadoop.hbase.mapred.TestDriver
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.584 sec
Running org.apache.hadoop.hbase.mapred.TestGroupingTableMap
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.542 sec
Running org.apache.hadoop.hbase.mapred.TestIdentityTableMap
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.893 sec
Running org.apache.hadoop.hbase.mapred.TestRowCounter
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.023 sec
Running org.apache.hadoop.hbase.mapred.TestSplitTable
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.623 sec
Running org.apache.hadoop.hbase.mapred.TestTableInputFormat
Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 25.652 sec
Running org.apache.hadoop.hbase.mapred.TestTableMapReduce
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 189.506 sec
Running org.apache.hadoop.hbase.mapred.TestTableMapReduceUtil
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 36.731 sec
Results :
Tests run: 28, Failures: 0, Errors: 0, Skipped: 0
{noformat}
My only request is for more comments. Tests names are nice, but test comments
are helpful for test maintainers and super helpful for new users looking to
learn APIs.
+1 from me otherwise.
> Improve test coverage in pkg org.apache.hadoop.hbase.mapred
> -----------------------------------------------------------
>
> Key: HBASE-8611
> URL: https://issues.apache.org/jira/browse/HBASE-8611
> Project: HBase
> Issue Type: Test
> Reporter: Vadim Bondarev
> Assignee: Vadim Bondarev
> Attachments: HBASE-8611-0.94-a.patch, HBASE-8611-trunk-a.patch,
> HBASE-8611-trunk-b.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
