[
https://issues.apache.org/jira/browse/HBASE-8627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13669129#comment-13669129
]
Anoop Sam John commented on HBASE-8627:
---------------------------------------
Thanks for the review Jon & Sergey.
{quote}
What are we planning to remove? the meta entry? this message?
{code}
+ if (!recordMetaRegion()) {
+ // Will remove later if we can fix it
+ errors.reportError("Fatal error: unable to get .META. region location.
Exiting...");
{code}
{quote}
This is an existing piece of code. This is the case when HBCK not able to get
the META location from zookeeper. Right now we are not having a way to fix it.
This comment means we can remove this error reporting once we can fix this
issue. I am not fixing this/changing this comment. Pls see this code is moved
from another method
{code}
- if (!recordMetaRegion()) {
- // Will remove later if we can fix it
- errors.reportError("Fatal error: unable to get root region location.
Exiting...");
- return false;
- }
{code}
bq. We need to "fix" it twice? why? (explain with comment please)
No need to fix twice. After fix calling hbck to assert no errors. At that time
I can pass fix as false. A copy paste resulted in this param to be true.
Corrected that now.
bq.Null is for a coder. Maybe turn this message into something more admin
friendly?
Actually we will never get this message(as per the new code). Before the
checkMetaRegion() we do read the meta location from the zookeeper and adding an
entry in regionInfoMap. Also we record regions from RS online regions into
regionInfoMap. In both these places I am having checks to make sure only one
entry, corresponding to the meta, is getting added into regionInfoMap. If we
can not get the meta location even from zookeeper, we exit with a fatal error
message. What we need to check is the deployed servers being 0 or >1. I am just
deleting this if check. This will address Sergey's comment as well
> HBCK can not fix meta not assigned issue
> ----------------------------------------
>
> Key: HBASE-8627
> URL: https://issues.apache.org/jira/browse/HBASE-8627
> Project: HBase
> Issue Type: Bug
> Components: hbck
> Affects Versions: 0.95.0
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Attachments: HBASE-8627_Trunk.patch, HBASE-8627_Trunk-V2.patch
>
>
> When meta table region is not assigned to any RS, HBCK run will get
> exception. I can see code added in checkMetaRegion() to solve this issue but
> it wont work. It still refers to ROOT region!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
