[ 
https://issues.apache.org/jira/browse/HBASE-8645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13670368#comment-13670368
 ] 

stack commented on HBASE-8645:
------------------------------

Here is how it changes lot output:

Before this patch:

{code}
2013-05-30 03:54:21,542 INFO  
[RegionServer:0;asf001.sp2.ygridcore.net,58265,1369886061348] 
zookeeper.RecoverableZooKeeper(119): Process identifier=regionserver:58265 
connecting to ZooKeeper ensemble=localhost:60188
2013-05-30 03:54:21,544 INFO  
[RegionServer:1;asf001.sp2.ygridcore.net,56020,1369886061408] 
zookeeper.RecoverableZooKeeper(119): Process identifier=regionserver:56020 
connecting to ZooKeeper ensemble=localhost:60188
2013-05-30 03:54:21,545 DEBUG 
[RegionServer:0;asf001.sp2.ygridcore.net,58265,1369886061348-EventThread] 
zookeeper.ZooKeeperWatcher(307): regionserver:58265 Received ZooKeeper Event, 
type=None, state=SyncConnected, path=null
2013-05-30 03:54:21,546 INFO  
[RegionServer:2;asf001.sp2.ygridcore.net,59675,1369886061430] 
zookeeper.RecoverableZooKeeper(119): Process identifier=regionserver:59675 
connecting to ZooKeeper ensemble=localhost:60188
2013-05-30 03:54:21,547 DEBUG 
[RegionServer:1;asf001.sp2.ygridcore.net,56020,1369886061408-EventThread] 
zookeeper.ZooKeeperWatcher(307): regionserver:56020 Received ZooKeeper Event, 
type=None, state=SyncConnected, path=null
2013-05-30 03:54:21,547 DEBUG 
[RegionServer:0;asf001.sp2.ygridcore.net,58265,1369886061348-EventThread] 
zookeeper.ZooKeeperWatcher(384): regionserver:58265-0x13ef3926fe10001 connected
2013-05-30 03:54:21,549 DEBUG 
[RegionServer:1;asf001.sp2.ygridcore.net,56020,1369886061408-EventThread] 
zookeeper.ZooKeeperWatcher(384): regionserver:56020-0x13ef3926fe10002 connected
2013-05-30 03:54:21,550 DEBUG 
[RegionServer:1;asf001.sp2.ygridcore.net,56020,1369886061408] 
zookeeper.ZKUtil(431): regionserver:56020-0x13ef3926fe10002 Set watcher on 
existing znode=/hbase/master
2013-05-30 03:54:21,550 DEBUG 
[RegionServer:0;asf001.sp2.ygridcore.net,58265,1369886061348] 
zookeeper.ZKUtil(431): regionserver:58265-0x13ef3926fe10001 Set watcher on 
existing znode=/hbase/master
2013-05-30 03:54:21,551 DEBUG 
[RegionServer:2;asf001.sp2.ygridcore.net,59675,1369886061430-EventThread] 
zookeeper.ZooKeeperWatcher(307): regionserver:59675 Received ZooKeeper Event, 
type=None, state=SyncConnected, path=null
{code}


After this patch:

{code}
...
2013-05-30 11:53:17,685 INFO  [RS:1;asf000,49894,1369914797554] 
zookeeper.RecoverableZooKeeper(119): Process identifier=regionserver:49894 
connecting to ZooKeeper ensemble=localhost:53298
2013-05-30 11:53:17,685 INFO  [RS:2;asf000,54417,1369914797577] 
zookeeper.RecoverableZooKeeper(119): Process identifier=regionserver:54417 
connecting to ZooKeeper ensemble=localhost:53298
2013-05-30 11:53:17,686 INFO  [RS:0;asf000,52780,1369914797476] 
zookeeper.RecoverableZooKeeper(119): Process identifier=regionserver:52780 
connecting to ZooKeeper ensemble=localhost:53298
2013-05-30 11:53:17,689 DEBUG [RS:1;asf000,49894,1369914797554-EventThread] 
zookeeper.ZooKeeperWatcher(307): regionserver:49894 Received ZooKeeper Event, 
type=None, state=SyncConnected, path=null
2013-05-30 11:53:17,689 DEBUG [RS:2;asf000,54417,1369914797577-EventThread] 
zookeeper.ZooKeeperWatcher(307): regionserver:54417 Received ZooKeeper Event, 
type=None, state=SyncConnected, path=null
2013-05-30 11:53:17,690 DEBUG [RS:0;asf000,52780,1369914797476-EventThread] 
zookeeper.ZooKeeperWatcher(307): regionserver:52780 Received ZooKeeper Event, 
type=None, state=SyncConnected, path=null
2013-05-30 11:53:17,690 DEBUG [RS:1;asf000,49894,1369914797554-EventThread] 
zookeeper.ZooKeeperWatcher(384): regionserver:49894-0x13ef548eb090001 connected
2013-05-30 11:53:17,691 DEBUG [RS:2;asf000,54417,1369914797577-EventThread] 
zookeeper.ZooKeeperWatcher(384): regionserver:54417-0x13ef548eb090002 connected
2013-05-30 11:53:17,691 DEBUG [RS:0;asf000,52780,1369914797476-EventThread] 
zookeeper.ZooKeeperWatcher(384): regionserver:52780-0x13ef548eb090003 connected
2013-05-30 11:53:17,692 DEBUG [RS:2;asf000,54417,1369914797577] 
zookeeper.ZKUtil(431): regionserver:54417-0x13ef548eb090002 Set watcher on 
existing znode=/hbase/master
2013-05-30 11:53:17,692 DEBUG [RS:0;asf000,52780,1369914797476] 
zookeeper.ZKUtil(431): regionserver:52780-0x13ef548eb090003 Set watcher on 
existing znode=/hbase/master
2013-05-30 11:53:17,693 DEBUG [RS:1;asf000,49894,1369914797554] 
zookeeper.ZKUtil(431): regionserver:49894-0x13ef548eb090001 Set watcher on 
existing znode=/hbase/master
2013-05-30 11:53:17,699 DEBUG [RS:2;asf000,54417,1369914797577] 
zookeeper.ZKUtil(433): regionserver:54417-0x13ef548eb090002 Set watcher on 
znode that does not yet exist, /hbase/running
2013-05-30 11:53:17,699 DEBUG [RS:1;asf000,49894,1369914797554] 
zookeeper.ZKUtil(433): regionserver:49894-0x13ef548eb090001 Set watcher on 
znode that does not yet exist, /hbase/running
2013-05-30 11:53:17,699 DEBUG [RS:0;asf000,52780,1369914797476] 
zookeeper.ZKUtil(433): regionserver:52780-0x13ef548eb090003 Set watcher on 
znode that does not yet exist, /hbase/running
2013-05-30 11:53:18,077 DEBUG [M:0;asf000,43595,1369914797223] 
util.FSUtils(757): Created cluster ID file at 
hdfs://localhost:54762/user/jenkins/hbase/hbase.id with ID: 
a908a854-197b-4e6c-a91f-c4d8f071c404
...
{code}

Notice thread names.

Any chance of a +1?

Need to make our logs readable
                
> Change ServerName so it uses hostname  only, not FQDN hostnames
> ---------------------------------------------------------------
>
>                 Key: HBASE-8645
>                 URL: https://issues.apache.org/jira/browse/HBASE-8645
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: stack
>            Assignee: stack
>         Attachments: 8645.txt, 8645.txt, 8645v2.txt, 8645v3.txt, 8645v4.txt
>
>
> No need of dragging around domain part of a hostname when we make 
> ServerNames.  Rather than do a.example.org,60000,12345 as we currently do, 
> just output: 1,60000,12345. This will make names displayed in UI and or shell 
> smaller.  Will also tighten up our logs a little, especially where ServerName 
> is part of a thrad name.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to