[
https://issues.apache.org/jira/browse/HBASE-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13670933#comment-13670933
]
stack commented on HBASE-8657:
------------------------------
bq. Why remove []-s around toStringBinary, it makes it harder to read (or sed)
from the log
Because it is out of form w/ the rest of the logging. No where else do we have
this square bracket delimiting. If you want to go there, lets do it
everywhere... else lets not introduce yet another new delimiter. For example:
We used to delimit name and value as:
<name>':' <value>
We then moved to:
<name>'='<value>
... it is easy enough to grep for and we were pretty good at putting it
everywhere. Lists were delimited by a ','.
Then, along came ruby with it s '=>' delimiter and its bracketing for lists and
maps.
An intern at facebook made some progress formatting the slow query detail as
JSON.
Then there was protobuf which is like the original ':' only there is no
delimiter between attributes -- no ',' -- just a space.
Then you came along w/ the square bracket which I suppose is a ruby 'list' only
we don't really do ruby lists in our logs.
I would love to do a standard. We wouldn't have to go there all in one go but
we could write it up and then aim for it.
Good on you Sergey.
> Miscellaneous log fixups for hbase-it; tidier logging, fix a few NPEs
> ---------------------------------------------------------------------
>
> Key: HBASE-8657
> URL: https://issues.apache.org/jira/browse/HBASE-8657
> Project: HBase
> Issue Type: Sub-task
> Reporter: stack
> Assignee: stack
> Fix For: 0.98.0, 0.95.1
>
> Attachments: fixup2.txt, fixups.txt
>
>
> This is a miscellaneous set of fixups that come of my staring at hbase-it
> logs trying to follow what is going on.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
