[ 
https://issues.apache.org/jira/browse/HBASE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13671186#comment-13671186
 ] 

Hadoop QA commented on HBASE-8640:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12585552/HBASE-8640.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 
1.0 profile.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5897//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5897//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5897//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5897//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5897//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5897//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5897//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5897//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5897//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5897//console

This message is automatically generated.
                
> ServerName in master may not initialize with the configured ipc address of 
> hbase.master.ipc.address
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-8640
>                 URL: https://issues.apache.org/jira/browse/HBASE-8640
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>            Reporter: rajeshbabu
>            Assignee: rajeshbabu
>             Fix For: 0.98.0, 0.95.2, 0.94.9
>
>         Attachments: HBASE-8640.patch
>
>
> We are starting rpc server with default interface hostname or configured ipc 
> address
> {code}
>     this.rpcServer = HBaseRPC.getServer(this,
>       new Class<?>[]{HMasterInterface.class, HMasterRegionInterface.class},
>         initialIsa.getHostName(), // This is bindAddress if set else it's 
> hostname
>         initialIsa.getPort(),
>         numHandlers,
>         0, // we dont use high priority handlers in master
>         conf.getBoolean("hbase.rpc.verbose", false), conf,
>         0); // this is a DNC w/o high priority handlers
> {code}
> But we are initialzing servername with default hostname always master znode 
> also have this hostname.
> {code}
>     String hostname = Strings.domainNamePointerToHostName(DNS.getDefaultHost(
>       conf.get("hbase.master.dns.interface", "default"),
>       conf.get("hbase.master.dns.nameserver", "default")));
>       ...
>     this.serverName = new ServerName(hostname,
>       this.isa.getPort(), System.currentTimeMillis());
> {code}
> If both default interface hostname and configured ipc address are not same 
> clients will get MasterNotRunningException.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to