[
https://issues.apache.org/jira/browse/HBASE-8598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13671841#comment-13671841
]
Ted Yu commented on HBASE-8598:
-------------------------------
{code}
+ * The class that provides optional request metrics to load-test-like tools.
+ * Methods are not thread safe unless otherwise noted.
+ */
+public class MultiActionMetrics {
{code}
Should the class be called MultiActionMetricsProvider ?
{code}
+ baseTime = System.currentTimeMillis();
{code}
Please use EnvironmentEdge.
{code}
+ /** @return Combined latency CDF for all requests from all threads. Call
after test. */
+ public ArrayList<Pair<Long, Long>> getCombinedCdf() {
{code}
Add javadoc for the meaning of return value.
> enhance multithreadedaction/reader/writer to test better
> --------------------------------------------------------
>
> Key: HBASE-8598
> URL: https://issues.apache.org/jira/browse/HBASE-8598
> Project: HBase
> Issue Type: Improvement
> Components: test
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-8598-v0.patch
>
>
> To be able to test more varied scenarios, I am adding delete and overwrite
> threads to writer; adding random read thread to reader; and adding some
> machine-oriented (csv) metric collection (QPS, histogram of all requests
> during the tests) because grepping logs for such stuff is PITA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
