[
https://issues.apache.org/jira/browse/HBASE-8672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13675204#comment-13675204
]
Nick Dimiduk commented on HBASE-8672:
-------------------------------------
IntegrationTestBulkLoad.java is missing the license header.
{noformat}
+ if (lc.getRk() != 0l) throw new RuntimeException("Chains should all
start at 0 rk");
{noformat}
nit: use '0L' instead of '0l' which looks a lot like '01'.
{noformat}
+ conf.setStrings("io.serializations", conf.get("io.serializations"),
+ KeyValueSerialization.class.getName());
{noformat}
Why does this become necessary (or, rather, why wasn't it necessary before)?
{noformat}
+
+ void setFirstRow(byte[] userInput);
+
+ void setLastRow(byte[] userInput);
{noformat}
nit: please javadoc interface methods.
> Create an Integration test for Bulk Loads
> -----------------------------------------
>
> Key: HBASE-8672
> URL: https://issues.apache.org/jira/browse/HBASE-8672
> Project: HBase
> Issue Type: Bug
> Components: regionserver, test
> Affects Versions: 0.98.0, 0.95.1
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-8672-0.patch, HBASE-8672-1.patch,
> HBASE-8672-2.patch
>
>
> Bulk loads and MR are not well tested using our IT tests. We should add a
> test that bulk loads hfiles and then scans over the resulting table to make
> sure that all the data is there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
