[ 
https://issues.apache.org/jira/browse/HBASE-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13677566#comment-13677566
 ] 

Sergey Shelukhin commented on HBASE-8696:
-----------------------------------------

{quote}
+    // Put encoded name first as that is what we search for most; having it 
show in logs first
+    // helps grepping around.

+    // I saw 6k exceptions thrown when a server went down w/ lots of regions 
with an
+    // outstanding bulk write.
{quote}
These comments are about the change, not about the lines...

{code}
-      LOG.trace("Current INFO from scan results = " + info);
{code} 
This line is annoying when trace is enabled, is it possible to keep something 
in it to make it easier to grep -v?

Are you sure the exceptions need to be minimized? It's trace logging after all, 
if I am looking at such level I'd rather see 6k than not see the one I need :) 
Maybe if they are all the same it could de-dup the list using some rough 
callstack compare, although that will be more complicated
                
> Fixup for logs that show when running hbase-it tests.
> -----------------------------------------------------
>
>                 Key: HBASE-8696
>                 URL: https://issues.apache.org/jira/browse/HBASE-8696
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: stack
>            Assignee: stack
>             Fix For: 0.95.1
>
>         Attachments: 8698.txt
>
>
> I've been staring at logs trying to figure why hbase-it tests fail.
> Here are some more log cleanups that come of my frustration trying to read 
> our emissions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to