[ 
https://issues.apache.org/jira/browse/HBASE-8690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13677596#comment-13677596
 ] 

Hadoop QA commented on HBASE-8690:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12586588/8690-trunk-v3.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 15 new 
or modified tests.

    {color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 
1.0 profile.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 1 
warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       
org.apache.hadoop.hbase.security.access.TestAccessController

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5961//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5961//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5961//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5961//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5961//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5961//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5961//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5961//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5961//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/5961//console

This message is automatically generated.
                
> Reduce unnecessary getFileStatus hdfs calls in TTL hfile and hlog cleanners
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-8690
>                 URL: https://issues.apache.org/jira/browse/HBASE-8690
>             Project: HBase
>          Issue Type: Improvement
>          Components: master
>            Reporter: Liu Shaohui
>            Priority: Minor
>         Attachments: 8690-trunk-v3.patch, HBASE-8690-0.94-v1.patch, 
> HBASE-8690-trunk-v1.patch, HBASE-8690-trunk-v2.patch
>
>
> For each in file in archive dir, the TimeToLiveHFileCleaner need call 
> getFileStatus to get the modify time of file. Actually the CleanerChore have 
> had the file status when listing its parent dir. 
> When we set the TTL to 7 days in our cluster for data security, the number of 
> files left in archive dir is up to 65 thousands. In each clean period, 
> TimeToLiveHFileCleaner will generate ten thousand getFileStatus call in a 
> short time, which is very heavy for hdfs namenode.
> Fix: Change the path param to FileStatus in isFileDeletable method and reduce 
> unnecessary getFileStatus hdfs calls in TTL cleaners.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to