[
https://issues.apache.org/jira/browse/HBASE-8702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13677620#comment-13677620
]
Sergey Shelukhin commented on HBASE-8702:
-----------------------------------------
{code}
+ public static final String WAL_CELL_CODEC_CLASS_KEY =
"hbase.regionserver.wal.codec";
{code}
Please don't put in HConstants...
{code}
+ WALCellCodec codec = codecClazz.newInstance();
+ codec.init(conf, compression);
{code}
ReflectionUtils::instantiateWithCustomCtor calls a custom ctor, then there's no
need for init method, removing final, etc.
Btw, trunk right now doesn't handle CompressionContext very well, it has to be
set for WALEdit/HLogKey (there are some TODOs there), not sure if it would have
implications for custom codecs
Otherwise looks good.
> Make WALEditCodec pluggable
> ---------------------------
>
> Key: HBASE-8702
> URL: https://issues.apache.org/jira/browse/HBASE-8702
> Project: HBase
> Issue Type: Improvement
> Components: Replication, wal
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.98.0, 0.95.2, 0.94.9
>
> Attachments: hbase-8702-0.94-v0.patch, hbase-8702-trunk-v0.patch
>
>
> WALEditCode needs to be pluggable to support alternative serialziation
> mechanisms.
> The open question here is whether to support the alternative codec when doing
> replication - both clusters would need the codec on the classpath, which has
> additional overhead and also will be a little bit complicated when making the
> WAL serialization backwards compatible in 0.94.
> This is the follow-up to HBASE-8636.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
