[ 
https://issues.apache.org/jira/browse/HBASE-8726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13680646#comment-13680646
 ] 

Elliott Clark commented on HBASE-8726:
--------------------------------------

bq.passing HBaseAdmin is not necessary, Action class has context that has 
admin, as well as other random stuff.

The context class is all private with a comment about how whoever wrote the 
actions wanted the internals to be private so I went the route of passing an 
admin.

bq.Action is called policy which is kind of confusing.
True.  I'll rename those.

bq.You are making online changes enabled by default, is this intended in this 
JIRA?
Yes when we can get this to run stablely for hours I would like to make it 
default.  Until then I don't think committing this is right yet.

This test exposed HBASE-8732 in the first 10 mins. So I expect there are still 
more bugs before we can make it default.
                
> Create an Integration Test for online schema change
> ---------------------------------------------------
>
>                 Key: HBASE-8726
>                 URL: https://issues.apache.org/jira/browse/HBASE-8726
>             Project: HBase
>          Issue Type: Bug
>          Components: Admin
>    Affects Versions: 0.98.0, 0.95.1
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>         Attachments: HBASE-8726-0.patch
>
>
> With table locks in place it should be time to start really testing online 
> table schema changes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to