[
https://issues.apache.org/jira/browse/HBASE-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13681235#comment-13681235
]
Nicolas Liochon commented on HBASE-4360:
----------------------------------------
The DeadServer already contains a map for the death time. For consistency:
- you should at the very least have exactly the same value. With the current
patch we could have 1ms difference sometimes and this might create confusion in
the future.
- you should may be not add another field in ServerName(no strong opinion)
- or you should change DeadServer to use the field you added in ServerName (no
strong opinion)
Now it's strange to have a class called ServerName that includes a death time.
> Maintain information on the time a RS went dead
> -----------------------------------------------
>
> Key: HBASE-4360
> URL: https://issues.apache.org/jira/browse/HBASE-4360
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Priority: Minor
> Attachments: HBASE-4360_1.patch, HBASE-4360_2.patch,
> master-status1.png
>
>
> Just something that'd be generally helpful, is to maintain DeadServer info
> with the last timestamp when it was determined as dead.
> Makes it easier to hunt the logs, and I don't think its much too expensive to
> maintain (one additional update per dead determination).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
